Storage proposal UI #321
Merged
Storage proposal UI #321
+2,016
−578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseivanlopez
force-pushed
the
storage-proposal-ui
branch
4 times, most recently
from
0d17080
to
2b70b64
Compare
This was referenced Nov 25, 2022
joseivanlopez
force-pushed
the
storage-proposal-ui
branch
3 times, most recently
from
1e58059
to
9973234
Compare
dgdavid
reviewed
Nov 28, 2022
joseivanlopez
force-pushed
the
storage-proposal-ui
branch
from
89eb0f8
to
818c3a4
Compare
dgdavid
force-pushed
the
storage-proposal-ui
branch
from
c3ab88e
to
0b8f661
Compare
joseivanlopez
force-pushed
the
storage-proposal-ui
branch
from
0b8f661
to
db38cff
Compare
dgdavid
force-pushed
the
storage-proposal-ui
branch
2 times, most recently
from
8847bc7
to
21c18c8
Compare
joseivanlopez
force-pushed
the
storage-proposal-ui
branch
from
3a34d2e
to
bc42724
Compare
joseivanlopez
force-pushed
the
storage-proposal-ui
branch
2 times, most recently
from
5a46470
to
5055652
Compare
joseivanlopez
force-pushed
the
storage-proposal-ui
branch
from
5055652
to
35416c4
Compare
imobachgs
approved these changes
Dec 2, 2022
joseivanlopez
force-pushed
the
storage-proposal-ui
branch
from
2dedcfc
to
88334f1
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the storage proposal allows selecting only the device to install into. But the YaST storage proposal is much more powerful and resilient. Some options like selecting LVM or encryption should be offered at installation time.
Solution
Add a new storage proposal UI. The installation summary has a link to go to a specific page for configuring the storage proposal. For now, it only offers LVM and encryption settings. This new page will be extended to configure the volumes to create.
Testing
Note: some unit tests are missing, for example for
ProposalSettingsSectionand for the storage client. They will be added later because we want to generate a new ISO as soon as possible.Screenshots